@WisdomPill I ran (many) of these tests against many python versions locally, and they passed. Can we see if they run through your CI? If not - maybe I can help.

Equally - I'd love to turn back to this issue regarding tox + dockers, and lend a hand!

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.5%. Comparing base (9d572cd) to head (3508301).
⚠️ Report is 254 commits behind head on master.

@@          Coverage Diff           @@
##           master    #607   +/-   ##
======================================
  Coverage    57.5%   57.5%           
======================================
  Files          39      39           
  Lines        2528    2528           
  Branches       75      74    -1     
======================================
  Hits         1452    1452           
  Misses       1059    1059           
  Partials       17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thanks @chayim for the contribution.

Do you know if redis-py 3.x.x was supporting an older python version?

It is just mypy is crashing, I will have a shot at it locally in the following days.
The other is towncrier which is a tool to update CHANGELOG.rst. Have a look at the history of changelon.d here, and the config file here.

About tox and docker, I would love to go back and finish that PR!

@WisdomPill redis-py 3.x.x stopped being tested after redis ~6 I think. We're a few versions past that.

If you'd like, I can help you use the release-drafter, as we are in Redis. It's similar to towncrier, except that it flat out takes the name of the PR, and uses labels. You know me... lazy ;)

But the mypy issue could be the result of our finally embracing type hints in redis-py. It could both be out of date, and possibly crashing due to duplicates?

Hi @chayim @WisdomPill, I was going to raise an issue here to bump Redis in light of the recent vulnerability redis/redis-py#2665 but found this pre-existing PR. Any chance of getting this PR bumped to >=4.5.4 and merged?

oh, sure! thanks @elichad

@WisdomPill I merged in, resolved, and updated redis-py but I don't grok the pre-commit.ci issue. Can you lend I hand?

I did manually build a package locally (build/sdist) just to see if I had inadvertently broken something,.

I saw that error in my day to day job, a simple upgrade of dependencies in pre-commit fixes the issues @chayim could you merge again master into your branch?

Is this PR still relevant, considering the latest version in setup.cfg?